Re: [PATCH] REFTABLE_REALLOC_ARRAY: fix potential memory leak if realloc failed

From: Junio C Hamano <gitster@pobox.com>
Date: May 9, 2025, 03:43 UTC
Message-ID: <xmqqzffm30vs.fsf@gitster.g>
In-Reply-To: <174cb568-e2bd-41e0-b090-eadd919d1ddd@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 7 quoted lines

> Am 08.05.25 um 15:39 schrieb Lidong Yan via GitGitGadget:
>> From: Lidong Yan <502024330056@smail.nju.edu.cn>
>> 
>> REFTABLE_REALLOC_ARRAY doesn't free origin pointer when reftable_realloc
>> failed. This leak can be fixed by add a free(x) before set x to NULL.
>
> Hmm, this macro is unused.  Perhaps remove it?

Or let the sleeping dog alone, perhaps?