git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] REFTABLE_REALLOC_ARRAY: remove this unsafe yet unused macro

From
Junio C Hamano <gitster@pobox.com>
Date
May 9, 2025, 14:25 UTC
Message-ID
<xmqqv7q93lor.fsf@gitster.g>
In-Reply-To
<aB27k8DI3BNgiwS-@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 7 quoted lines
> On Fri, May 09, 2025 at 07:44:46AM +0000, Lidong Yan via GitGitGadget wrote:
>> From: Lidong Yan <502024330056@smail.nju.edu.cn>
>> 
>> REFTABLE_REALLOC_ARRAY will cause memory leak if realloc failed.
>> Since it is unused, remove this unsafe macro.
>
> This looks good to me, thanks!

Alright. As long as we do not foresee adding a new caller of this in the near future, removal is always preferred ;-)

Thanks.
Previous: Patrick Steinhardt
Message 10 of 10 in “REFTABLE_REALLOC_ARRAY: fix potential memory leak if realloc failed”
  1. REFTABLE_REALLOC_ARRAY: fix potential memory leak if realloc failedLidong Yan via GitGitGadget, May 8, 2025
  2. René ScharfeMay 8, 2025
  3. lidongyanMay 9, 2025
  4. Junio C HamanoMay 9, 2025
  5. REFTABLE_REALLOC_ARRAY: remove this unsafe yet unused macroLidong Yan via GitGitGadget, May 9, 2025
  6. Patrick SteinhardtMay 9, 2025
  7. lidongyanMay 9, 2025
  8. REFTABLE_REALLOC_ARRAY: remove this unsafe yet unused macroLidong Yan via GitGitGadget, May 9, 2025
  9. Patrick SteinhardtMay 9, 2025
  10. Junio C HamanoMay 9, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.