Re: [PATCH v3] REFTABLE_REALLOC_ARRAY: remove this unsafe yet unused macro
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 9, 2025, 14:25 UTC
- Message-ID
- <xmqqv7q93lor.fsf@gitster.g>
- In-Reply-To
- <aB27k8DI3BNgiwS-@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 7 quoted lines
> On Fri, May 09, 2025 at 07:44:46AM +0000, Lidong Yan via GitGitGadget wrote: >> From: Lidong Yan <502024330056@smail.nju.edu.cn> >> >> REFTABLE_REALLOC_ARRAY will cause memory leak if realloc failed. >> Since it is unused, remove this unsafe macro. > > This looks good to me, thanks!
Alright. As long as we do not foresee adding a new caller of this in the near future, removal is always preferred ;-)
Thanks.