Re: [PATCH v2] REFTABLE_REALLOC_ARRAY: remove this unsafe yet unused macro
- From
Patrick Steinhardt <ps@pks.im>
- Date
- May 9, 2025, 06:51 UTC
- Message-ID
- <aB2l_WaBFyz5POld@pks.im>
- In-Reply-To
- <pull.1955.v2.git.git.1746756263207.gitgitgadget@gmail.com>
On Fri, May 09, 2025 at 02:04:22AM +0000, Lidong Yan via GitGitGadget wrote:
Show 20 quoted lines
> diff --git a/reftable/basics.h b/reftable/basics.h
> index d8888c12629..667feffd935 100644
> --- a/reftable/basics.h
> +++ b/reftable/basics.h
> @@ -199,16 +199,8 @@ static inline int reftable_alloc_size(size_t nelem, size_t elsize, size_t *out)
> (x) = reftable_malloc(alloc_size); \
> } \
> } while (0)
> -#define REFTABLE_CALLOC_ARRAY(x, alloc) (x) = reftable_calloc((alloc), sizeof(*(x)))
> -#define REFTABLE_REALLOC_ARRAY(x, alloc) do { \
> - size_t alloc_size; \
> - if (reftable_alloc_size(sizeof(*(x)), (alloc), &alloc_size) < 0) { \
> - errno = ENOMEM; \
> - (x) = NULL; \
> - } else { \
> - (x) = reftable_realloc((x), alloc_size); \
> - } \
> - } while (0)
> +#define REFTABLE_CALLOC_ARRAY(x, alloc) \
> + (x) = reftable_calloc((alloc), sizeof(*(x)))Let's avoid reformatting unrelated macros. But other than that I fully agree -- we should remove stuff that we don't use in the first place.
Thanks!
Patrick