Re: [PATCH v5 2/5] setup: sanity check file size in read_gitfile_gently
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 29, 2015, 15:42 UTC
- Message-ID
- <xmqqy4lb54bl.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1430030985-14499-3-git-send-email-erik.elfstrom@gmail.com>
Erik Elfström <erik.elfstrom@gmail.com> writes:
Show 10 quoted lines
> diff --git a/setup.c b/setup.c
> index c4538ca..792c37b 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -364,6 +364,10 @@ const char *read_gitfile_gently(const char *path, int *return_error_code)
> error_code = READ_GITFILE_ERR_OPEN_FAILED;
> goto cleanup_return;
> }
> + if (st.st_size > PATH_MAX * 4) {
> + error_code = READ_GITFILE_ERR_TOO_LARGE;You have fd already open for the path at this point. When you reroll, please do not forget to close(fd) here.
> + goto cleanup_return; > + }