Re: [PATCH v5 4/5] p7300: add performance tests for clean
- From
erik elfström <erik.elfstrom@gmail.com>
- Date
- Apr 28, 2015, 19:36 UTC
- Message-ID
- <CAMpP7NZM2CUbL_UEJozbgzb9yDnSp29B4hj7XY4pVKA_OZDgRg@mail.gmail.com>
- In-Reply-To
- <20150428063311.GN24580@peff.net>
On Tue, Apr 28, 2015 at 8:33 AM, Jeff King <peff@peff.net> wrote:
Show 10 quoted lines
> > Do we actually need a large repo here? The real cost is coming from the > directories we create. We could actually start with a totally empty > repository if we wanted (though I don't think the t/perf system handles > that right now). But if there's not a reason to use the large repo, I > think using test_perf_default_repo is better, as it works out of the box > without specifying extra environment variables (well, it works either > way, but you get a nasty warning from perf-lib.sh). > > -Peff
Sure, I'll change this to the default. I wasn't sure about the performance characteristics of clean (does working tree size matter?) when I started so it felt safest to go with a large repo.