Re: [PATCH v5 1/5] setup: add gentle version of read_gitfile

From: Jeff King <peff@peff.net>
Date: Apr 28, 2015, 20:48 UTC
Message-ID: <20150428204853.GA12153@peff.net>
In-Reply-To: <20150428204213.GO5467@google.com>

On Tue, Apr 28, 2015 at 01:42:13PM -0700, Jonathan Nieder wrote:

Show 9 quoted lines

> Jeff King wrote:
> 
> > But the NULL does not carry the information about _which_ error, and
> > Erik is suggesting that the caller may need to change behavior based on
> > that information. IOW, his current patch (return NULL and set the
> > specific integer code in a variable) allows this, but switching the
> > integer code out for a human-readable strbuf does not.
> 
> Right.  Two ways to handle that are:

Sure, but "this system" that I was referring to one was not one of those ways. :)

Show 14 quoted lines

>  - two out parameters: an integer code and a human-readable string, or
> 
>  - an integer code returned using the ERR_PTR method and a
>    human-readable string out parameter
> 
> The point I was trying to make clear is that the human-readable error
> message and the integer to affect control flow have different purposes
> and are not tightly related except in that they are produced at the
> same time.
> 
> Using an integer to convey the human-readable error message (like errno
> does) unnecessarily forces the message to be more vague (by not being
> parameterized, and by always using the same error message for the same
> integer error).

Yes, I agree converting the integer back into a string later does not always carry all of the data. OTOH, the caller can often supply the context (i.e., this is basically how "errno" works). This gets back to the idea we discussed a while ago of having a "struct error" that can carry the code and the parameters (or if you like, the code and a finished error message). It just feels in some ways like that ends up with the worst of both worlds (a lot of boilerplate for integer codes, _and_ the allocation and cleanup issues associated with a string error message).

I dunno. I'd be interested to see a rough draft of an idea applied to a specific callsite.

-Peff