git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/WIP 3/8] am: implement patch queue mechanism

From
Junio C Hamano <gitster@pobox.com>
Date
May 27, 2015, 20:38 UTC
Message-ID
<xmqqy4k9kb6s.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1432733618-25629-4-git-send-email-pyokagan@gmail.com>
Paul Tan <pyokagan@gmail.com> writes:
Show 16 quoted lines
>  Makefile     |   2 +-
>  builtin.h    |   1 +
>  builtin/am.c | 167 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  git.c        |   1 +
>  4 files changed, 170 insertions(+), 1 deletion(-)
>  create mode 100644 builtin/am.c
>
> diff --git a/Makefile b/Makefile
> index 323c401..57a7c8c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -466,7 +466,6 @@ TEST_PROGRAMS_NEED_X =
>  # interactive shell sessions without exporting it.
>  unexport CDPATH
>  
> -SCRIPT_SH += git-am.sh

If you are building this "new am" incrementally (and for something complex like "am", that's the only sensible way), perhaps it is a good idea to do the "competing implementation" trick I suggested earlier when we were discussing your "new pull" patches, to allow you to keep both versions and switch between them at runtime. That way, you can run tests, both existing ones and new ones you add, on both versions to make sure they behave the same way.

Previous: Paul TanNext: Paul Tan
Message 11 of 24 in “Make git-am a builtin”
  1. 0/8 Make git-am a builtinPaul Tan, May 27, 2015
  2. 1/8 wrapper: implement xopen()Paul Tan, May 27, 2015
  3. Stefan BellerMay 27, 2015
  4. Torsten BögershausenMay 27, 2015
  5. Jeff KingMay 27, 2015
  6. Paul TanJun 3, 2015
  7. Paul TanJun 4, 2015
  8. 2/8 wrapper: implement xfopen()Paul Tan, May 27, 2015
  9. Jeff KingMay 27, 2015
  10. 3/8 am: implement patch queue mechanismPaul Tan, May 27, 2015
  11. Junio C HamanoMay 27, 2015
  12. 4/8 am: split out mbox/maildir patches with git-mailsplitPaul Tan, May 27, 2015
  13. Eric SunshineMay 28, 2015
  14. Paul TanJun 2, 2015
  15. 5/8 am: detect mbox patchesPaul Tan, May 27, 2015
  16. Eric SunshineMay 31, 2015
  17. 6/8 am: extract patch, message and authorship with git-mailinfoPaul Tan, May 27, 2015
  18. Junio C HamanoMay 27, 2015
  19. Jeff KingMay 27, 2015
  20. Paul TanJun 3, 2015
  21. Junio C HamanoMay 27, 2015
  22. Paul TanJun 3, 2015
  23. 7/8 am: apply patch with git-applyPaul Tan, May 27, 2015
  24. 8/8 am: commit applied patchPaul Tan, May 27, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.