git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH/WIP 7/8] am: apply patch with git-apply

From
Paul Tan <pyokagan@gmail.com>
Date
May 27, 2015, 13:33 UTC
Message-ID
<1432733618-25629-8-git-send-email-pyokagan@gmail.com>
In-Reply-To
<1432733618-25629-1-git-send-email-pyokagan@gmail.com>
Implement applying the patch to the index using git-apply.
Signed-off-by: Paul Tan <pyokagan@gmail.com>
---
 builtin/am.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 49 insertions(+), 1 deletion(-)
diff --git a/builtin/am.c b/builtin/am.c
index 0b8a42d..7126df3 100644
--- a/builtin/am.c
+++ b/builtin/am.c
@@ -25,6 +25,18 @@ static int is_empty_file(const char *filename)
 	return !st.st_size;
 }
 
+/**
+ * Returns the first line of msg
+ */
+static const char *firstline(const char *msg)
+{
+	static struct strbuf sb = STRBUF_INIT;
+
+	strbuf_reset(&sb);
+	strbuf_add(&sb, msg, strchrnul(msg, '\n') - msg);
+	return sb.buf;
+}
+
 enum patch_format {
 	PATCH_FORMAT_UNKNOWN = 0,
 	PATCH_FORMAT_MBOX
@@ -503,6 +515,29 @@ static int parse_patch(struct am_state *state, const char *patch)
 	return 0;
 }
 
+/*
+ * Applies current patch with git-apply. Returns 0 on success, -1 otherwise.
+ */
+static int run_apply(const struct am_state *state)
+{
+	struct child_process cp = CHILD_PROCESS_INIT;
+
+	cp.git_cmd = 1;
+
+	argv_array_push(&cp.args, "apply");
+	argv_array_push(&cp.args, "--index");
+	argv_array_push(&cp.args, am_path(state, "patch"));
+
+	if (run_command(&cp))
+		return -1;
+
+	/* Reload index as git-apply will have modified it. */
+	discard_cache();
+	read_cache();
+
+	return 0;
+}
+
 /**
  * Applies all queued patches.
  */
@@ -520,7 +555,20 @@ static void am_run(struct am_state *state)
 		write_file(am_path(state, "final-commit"), 1, "%s", state->msg.buf);
 		write_author_script(state);
 
-		/* patch application not implemented yet */
+		printf_ln(_("Applying: %s"), firstline(state->msg.buf));
+
+		if (run_apply(state) < 0) {
+			int value;
+
+			printf_ln(_("Patch failed at %s %s"), msgnum(state),
+					firstline(state->msg.buf));
+
+			if (!git_config_get_bool("advice.amworkdir", &value) && !value)
+				printf_ln(_("The copy of the patch that failed is found in: %s"),
+						am_path(state, "patch"));
+
+			exit(128);
+		}
 
 next:
 		am_next(state);
-- 
2.1.4
Previous: Paul TanNext: Paul Tan
Message 23 of 24 in “Make git-am a builtin”
  1. 0/8 Make git-am a builtinPaul Tan, May 27, 2015
  2. 1/8 wrapper: implement xopen()Paul Tan, May 27, 2015
  3. Stefan BellerMay 27, 2015
  4. Torsten BögershausenMay 27, 2015
  5. Jeff KingMay 27, 2015
  6. Paul TanJun 3, 2015
  7. Paul TanJun 4, 2015
  8. 2/8 wrapper: implement xfopen()Paul Tan, May 27, 2015
  9. Jeff KingMay 27, 2015
  10. 3/8 am: implement patch queue mechanismPaul Tan, May 27, 2015
  11. Junio C HamanoMay 27, 2015
  12. 4/8 am: split out mbox/maildir patches with git-mailsplitPaul Tan, May 27, 2015
  13. Eric SunshineMay 28, 2015
  14. Paul TanJun 2, 2015
  15. 5/8 am: detect mbox patchesPaul Tan, May 27, 2015
  16. Eric SunshineMay 31, 2015
  17. 6/8 am: extract patch, message and authorship with git-mailinfoPaul Tan, May 27, 2015
  18. Junio C HamanoMay 27, 2015
  19. Jeff KingMay 27, 2015
  20. Paul TanJun 3, 2015
  21. Junio C HamanoMay 27, 2015
  22. Paul TanJun 3, 2015
  23. 7/8 am: apply patch with git-applyPaul Tan, May 27, 2015
  24. 8/8 am: commit applied patchPaul Tan, May 27, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.