Re: [PATCH/WIP 1/8] wrapper: implement xopen()
- From
Jeff King <peff@peff.net>
- Date
- May 27, 2015, 21:53 UTC
- Message-ID
- <20150527215307.GC23259@peff.net>
- In-Reply-To
- <55661513.8000306@web.de>
On Wed, May 27, 2015 at 09:03:47PM +0200, Torsten Bögershausen wrote:
Show 12 quoted lines
> The original open can take 2 or 3 parameters, how about this:
> int xopen(const char *path, int oflag, ... )
> {
> va_list params;
> int mode;
> int fd;
>
> va_start(params, oflag);
> mode = va_arg(params, int);
> va_end(params);
>
> fd = open(path, oflag, mode);Don't you need a conditional on pulling the mode arg off the stack (i.e., if O_CREAT is in the flags)?
-Peff