Re: [PATCH v4 1/7] quote: remove leading space in sq_dequote_step

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 29, 2016, 19:01 UTC
Message-ID: <xmqqy4a39w8b.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <56D40301.8020007@moritzneeb.de>

Moritz Neeb <lists@moritzneeb.de> writes:

Show 25 quoted lines

> Because sq_quote_argv adds a leading space (which is expected in trace.c),
> sq_dequote_step should remove this space again, such that the operations
> of quoting and dequoting are inverse of each other.
>
> This patch is preparing the way to remove some excessive trimming
> operation in bisect in the following commit.
>
> Signed-off-by: Moritz Neeb <lists@moritzneeb.de>
> ---
>  quote.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/quote.c b/quote.c
> index fe884d2..2714f27 100644
> --- a/quote.c
> +++ b/quote.c
> @@ -63,6 +63,8 @@ static char *sq_dequote_step(char *arg, char **next)
>  	char *src = arg;
>  	char c;
>  
> +	if (*src == ' ')
> +		src++;
>  	if (*src != '\'')
>  		return NULL;
>  	for (;;) {

If we look at this "for (;;)" loop, we notice that (1) it accepts as many spaces as there are between two quoted strings, and (2) it does not limit it to SP but uses isspace().

I wonder if you would instead want

	while (isspace(*src))
        	src++;

to be consistent?