Re: [PATCH v3 0/7] replacing strbuf_getline_lf() by strbuf_getline()

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Feb 28, 2016, 06:30 UTC
Message-ID: <CAPig+cSv=7zixz_BK=f0MhQnTTB-agB5=4aSrFE5vAJtOgbuGg@mail.gmail.com>
In-Reply-To: <56D28092.9090209@moritzneeb.de>

On Sun, Feb 28, 2016 at 12:07 AM, Moritz Neeb <lists@moritzneeb.de> wrote:

Show 13 quoted lines

> This series deals with strbuf_getline_lf() in certain codepaths:
> Those, where the input that is read, is/was trimmed before doing anything that
> could possibly expect a CR character. Those places can be assumed to be "text"
> input, where a CR never would be a meaningful control character.
> [...]
>
> Changes since v2:
>
> * Line splitting in notes_copy_from_stdin() is changed to string_list_split as
>   suggested by Eric Sunshine.
> * The behavior change in interactive cleaning from patch v2 is undone.
> * Some of the previous patches were broken because of some unexpected
>   whitespace. This should be fixed now.

In the future, as an aid to reviewers, please include an interdiff since the previous version, as well a link to the previous round[1]. It's also very helpful to say which patches have changed (and which have not).

Thanks.

[1]: http://thread.gmane.org/gmane.comp.version-control.git/285118/focus=286865