git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 0/7] replacing strbuf_getline_lf() by strbuf_getline()

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Feb 29, 2016, 18:26 UTC
Message-ID
<CAPig+cT4+bKS53E6bmLNn=xWkXK2Tx8N9bDEqGCNwNy-qjMOUg@mail.gmail.com>
In-Reply-To
<56D401C2.8020100@moritzneeb.de>
On Mon, Feb 29, 2016 at 3:30 AM, Moritz Neeb <lists@moritzneeb.de> wrote:
Show 7 quoted lines
> Although I was not sure [4], I decided to roll out v4, in the hope that the next
> reviewers will profit by the more polished commit messages and order.
>
> Changes since v3 [3] (the changes to single patches are indicated below):
>
>  * Commit messages refined
>  * Order of patch 4 and 5 in v2 was switched.

Thanks. With the exception of my commentary on patch 4/7, I think v4 addresses all my v3 review comments.

Previous: Eric SunshineNext: Moritz Neeb
Message 33 of 38 in “replacing strbuf_getline_lf() by strbuf_getline()”
  1. 0/7 replacing strbuf_getline_lf() by strbuf_getline()Moritz Neeb, Feb 28, 2016
  2. 1/7 quote: remove leading space in sq_dequote_stepMoritz Neeb, Feb 28, 2016
  3. 2/7 bisect: read bisect paths with strbuf_getline()Moritz Neeb, Feb 28, 2016
  4. Eric SunshineFeb 28, 2016
  5. Moritz NeebFeb 28, 2016
  6. 3/7 clean: read user input with strbuf_getline()Moritz Neeb, Feb 28, 2016
  7. Eric SunshineFeb 28, 2016
  8. Moritz NeebFeb 28, 2016
  9. 4/7 notes copy --stdin: split lines with string_list_split()Moritz Neeb, Feb 28, 2016
  10. Eric SunshineFeb 28, 2016
  11. Moritz NeebFeb 28, 2016
  12. Eric SunshineFeb 28, 2016
  13. 5/7 notes copy --stdin: read lines with strbuf_getline()Moritz Neeb, Feb 28, 2016
  14. 6/7 remote: read $GIT_DIR/branches/* with strbuf_getline()Moritz Neeb, Feb 28, 2016
  15. 7/7 wt-status: read rebase todolist with strbuf_getline()Moritz Neeb, Feb 28, 2016
  16. Eric SunshineFeb 28, 2016
  17. Moritz NeebFeb 28, 2016
  18. Moritz NeebFeb 28, 2016
  19. 0/7 replacing strbuf_getline_lf() by strbuf_getline()Moritz Neeb, Feb 29, 2016
  20. 1/7 quote: remove leading space in sq_dequote_stepMoritz Neeb, Feb 29, 2016
  21. Junio C HamanoFeb 29, 2016
  22. Moritz NeebFeb 29, 2016
  23. Moritz NeebFeb 29, 2016
  24. 2/7 bisect: read bisect paths with strbuf_getline()Moritz Neeb, Feb 29, 2016
  25. 3/7 clean: read user input with strbuf_getline()Moritz Neeb, Feb 29, 2016
  26. 5/7 notes copy --stdin: split lines with string_list_split()Moritz Neeb, Feb 29, 2016
  27. 6/7 remote: read $GIT_DIR/branches/* with strbuf_getline()Moritz Neeb, Feb 29, 2016
  28. 7/7 wt-status: read rebase todolist with strbuf_getline()Moritz Neeb, Feb 29, 2016
  29. 4/7 notes copy --stdin: read lines with strbuf_getline()Moritz Neeb, Feb 29, 2016
  30. Eric SunshineFeb 29, 2016
  31. Moritz NeebFeb 29, 2016
  32. Eric SunshineFeb 29, 2016
  33. Eric SunshineFeb 29, 2016
  34. Moritz NeebMar 9, 2016
  35. Junio C HamanoMar 9, 2016
  36. Moritz NeebMar 9, 2016
  37. Junio C HamanoMar 9, 2016
  38. Eric SunshineMar 9, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.