Re: [PATCH v3 1/4] imap-send: return with error if curl failed

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 23, 2017, 20:12 UTC
Message-ID: <xmqqy3qaxcur.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <da29995c-3c56-ac43-9f8f-12bf381711f3@morey-chaisemartin.com>

Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com> writes:

Show 21 quoted lines

> curl_append_msgs_to_imap always returned 0, whether curl failed or not.
> Return a proper status so git imap-send will exit with an error code
> if womething wrong happened.
>
> Signed-off-by: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
> ---
>  imap-send.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/imap-send.c b/imap-send.c
> index b2d0b849b..09f29ea95 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1490,7 +1490,7 @@ static int curl_append_msgs_to_imap(struct imap_server_conf *server,
>  	curl_easy_cleanup(curl);
>  	curl_global_cleanup();
>  
> -	return 0;
> +	return res == CURLE_OK;
>  }
>  #endif

Wait a bit. Did you mean "res != CURLE_OK"? If we got an OK, we want to return 0 as success, because the value we return from here is returned by cmd_main() as-is to main() and to the outside world, no?