git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/4] imap-send: return with error if curl failed

From
Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
Date
Aug 22, 2017, 15:56 UTC
Message-ID
<da29995c-3c56-ac43-9f8f-12bf381711f3@morey-chaisemartin.com>
In-Reply-To
<087f5907-6558-ce32-2f5c-2e418522c030@morey-chaisemartin.com>

curl_append_msgs_to_imap always returned 0, whether curl failed or not. Return a proper status so git imap-send will exit with an error code if womething wrong happened.

Signed-off-by: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
---
 imap-send.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/imap-send.c b/imap-send.c
index b2d0b849b..09f29ea95 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1490,7 +1490,7 @@ static int curl_append_msgs_to_imap(struct imap_server_conf *server,
 	curl_easy_cleanup(curl);
 	curl_global_cleanup();
 
-	return 0;
+	return res == CURLE_OK;
 }
 #endif
 
-- 
2.14.0.1.gd9597ce13
Previous: Nicolas Morey-ChaisemartinNext: Junio C Hamano
Message 2 of 13 in “imap-send: Fix and enable curl by default”
  1. 0/4 imap-send: Fix and enable curl by defaultNicolas Morey-Chaisemartin, Aug 22, 2017
  2. 1/4 imap-send: return with error if curl failedNicolas Morey-Chaisemartin, Aug 22, 2017
  3. Junio C HamanoAug 23, 2017
  4. Junio C HamanoAug 23, 2017
  5. Nicolas Morey-ChaisemartinAug 24, 2017
  6. 2/4 imap-send: add wrapper to get server credentials if neededNicolas Morey-Chaisemartin, Aug 22, 2017
  7. Junio C HamanoAug 23, 2017
  8. Nicolas Morey-ChaisemartinAug 24, 2017
  9. Junio C HamanoAug 24, 2017
  10. 3/4 imap_send: setup_curl: retreive credentials if not set in config fileNicolas Morey-Chaisemartin, Aug 22, 2017
  11. 4/4 imap-send: use curl by defaultNicolas Morey-Chaisemartin, Aug 22, 2017
  12. Junio C HamanoAug 23, 2017
  13. Nicolas Morey-ChaisemartinAug 24, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.