git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 4/4] imap-send: use curl by default

From
Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
Date
Aug 22, 2017, 15:56 UTC
Message-ID
<bb94cace-6bc5-2009-7c9d-a6965e3b84c6@morey-chaisemartin.com>
In-Reply-To
<087f5907-6558-ce32-2f5c-2e418522c030@morey-chaisemartin.com>

Now that curl is enable by default, use the curl implementation for imap too. The goal is to validate feature parity between the legacy and the curl implementation, deprecate thee legacy implementation later on and in the long term, hopefully drop it altogether.

Signed-off-by: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
---
 imap-send.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/imap-send.c b/imap-send.c
index a74d011a9..58c191704 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -35,11 +35,11 @@ typedef void *SSL;
 #include "http.h"
 #endif
 
-#if defined(USE_CURL_FOR_IMAP_SEND) && defined(NO_OPENSSL)
-/* only available option */
+#if defined(USE_CURL_FOR_IMAP_SEND)
+/* Always default to curl if it's available. */
 #define USE_CURL_DEFAULT 1
 #else
-/* strictly opt in */
+/* We don't have curl, so continue to use the historical implementation */
 #define USE_CURL_DEFAULT 0
 #endif
 
-- 
2.14.0.1.gd9597ce13
Previous: Nicolas Morey-ChaisemartinNext: Junio C Hamano
Message 11 of 13 in “imap-send: Fix and enable curl by default”
  1. 0/4 imap-send: Fix and enable curl by defaultNicolas Morey-Chaisemartin, Aug 22, 2017
  2. 1/4 imap-send: return with error if curl failedNicolas Morey-Chaisemartin, Aug 22, 2017
  3. Junio C HamanoAug 23, 2017
  4. Junio C HamanoAug 23, 2017
  5. Nicolas Morey-ChaisemartinAug 24, 2017
  6. 2/4 imap-send: add wrapper to get server credentials if neededNicolas Morey-Chaisemartin, Aug 22, 2017
  7. Junio C HamanoAug 23, 2017
  8. Nicolas Morey-ChaisemartinAug 24, 2017
  9. Junio C HamanoAug 24, 2017
  10. 3/4 imap_send: setup_curl: retreive credentials if not set in config fileNicolas Morey-Chaisemartin, Aug 22, 2017
  11. 4/4 imap-send: use curl by defaultNicolas Morey-Chaisemartin, Aug 22, 2017
  12. Junio C HamanoAug 23, 2017
  13. Nicolas Morey-ChaisemartinAug 24, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.