Re: [PATCH v2 1/1] remote-curl: unbreak http.extraHeader with custom allocators

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 8, 2019, 03:03 UTC
Message-ID: <xmqqy2wrnk6o.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.1911071338320.46@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> FWIW I would like to stick with "custom allocator" because even
> releasing the memory is the duty of an "allocator", even if that
> allocator happens to "deallocate" at that point what it has allocated
> before.

My preference is to think of the set of functions we feed curl-global-init-mem as a (allocator, deallocator, reallocator, ...) tuple.

But you are calling that set itself as an allocator that has service functions like (alloc, free, realloc), and as long as that (i.e. how you defined the word "allocator") is clear to the readers that is perfectly OK.

To me as one reader, it was not clear and that was where my comment came from.