Re: [PATCH 1/1] remote-curl: unbreak http.extraHeader with custom allocators
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 6, 2019, 09:49 UTC
- Message-ID
- <xmqqsgn1tjup.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.1911061009230.46@tvgsbejvaqbjf.bet>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 7 quoted lines
> On Tue, 5 Nov 2019, Jeff King wrote: > >> ... transforming it later into a curl_slist. I don't think that really buys >> us much, though. > > Alas, it _does_ buy us a lot, as I *just* found out (can you imagine how > glad I am not to have rushed out another Git for Windows release?).
Thanks both, and especially thanks Dscho for both for a fix and for restraining yourself from the urge to pull trigger too soon ;-)
> I will change the patch to avoid using `slist` early and send another > iteration.
Will look forward to seeing it.
Thanks.