Re: [PATCH 1/1] remote-curl: unbreak http.extraHeader with custom allocators

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 6, 2019, 19:38 UTC
Message-ID: <nycvar.QRO.7.76.6.1911062029230.46@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqsgn1tjup.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Wed, 6 Nov 2019, Junio C Hamano wrote:

Show 12 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > On Tue, 5 Nov 2019, Jeff King wrote:
> >
> >> ... transforming it later into a curl_slist. I don't think that really buys
> >> us much, though.
> >
> > Alas, it _does_ buy us a lot, as I *just* found out (can you imagine how
> > glad I am not to have rushed out another Git for Windows release?).
>
> Thanks both, and especially thanks Dscho for both for a fix and for
> restraining yourself from the urge to pull trigger too soon ;-)

Well, I _will_ trigger the pipeline publishing Git for Windows v2.24.0(2) in a moment, with this fix, but more importantly with a fix for the installer that tries to install some Cygwin-style symlinks, which was broken in non-US locales (most notably in a Japanese setup; apparently there _still_ are developers who did not yet move away from a Japanese locale... at least on Windows).

Ciao, Dscho

Show 8 quoted lines

>
> > I will change the patch to avoid using `slist` early and send another
> > iteration.
>
> Will look forward to seeing it.
>
> Thanks.
>