git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 00/10] Modernizing the t7001 test script

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 9, 2021, 22:58 UTC
Message-ID
<xmqqy2fwyhjy.fsf@gitster.c.googlers.com>
In-Reply-To
<20210209173254.17712-1-shubhunic@gmail.com>
shubham verma <shubhunic@gmail.com> writes:
Show 26 quoted lines
> In this patch series modernize the t7001 test script by changing the
> style of its tests from an old one to the modern one and by cleaning
> up the test script.
>
> Changes since v1:
>
> - Change commit messages and added brief explanation about commit.
> - Modernize subshell formatting
> - Use ': >' rather than '>'
>
> Thanks everyone for your feedback and suggestions.
>
> shubham verma (10):
>   t7001: modernize test formatting
>   t7001: indent with TABs instead of spaces
>   t7001: remove unnecessary blank lines
>   t7001: modernize subshell formatting
>   t7001: remove whitespace after redirect operators
>   t7001: avoid using `cd` outside of subshells
>   t7001: use '>' rather than 'touch'
>   t7001: put each command on a separate line
>   t7001: use here-docs instead of echo
>   t7001: use `test` rather than `[`
>
>  t/t7001-mv.sh | 432 ++++++++++++++++++++++++--------------------------
>  1 file changed, 204 insertions(+), 228 deletions(-)

I would have used test_write_lines instead of here-doc in 9/10, but that is such a minor preference thing that it is not worth going back and replace. Nothing else stood out during my cursory scan.

Will queue; thanks.
Previous: Eric SunshineNext: Eric Sunshine
Message 13 of 17 in “Modernizing the t7001 test script”
  1. 00/10 Modernizing the t7001 test scriptshubham verma, Feb 9, 2021
  2. 01/10 t7001: modernize test formattingshubham verma, Feb 9, 2021
  3. 02/10 t7001: indent with TABs instead of spacesshubham verma, Feb 9, 2021
  4. 03/10 t7001: remove unnecessary blank linesshubham verma, Feb 9, 2021
  5. 04/10 t7001: modernize subshell formattingshubham verma, Feb 9, 2021
  6. 09/10 t7001: use here-docs instead of echoshubham verma, Feb 9, 2021
  7. 07/10 t7001: use '>' rather than 'touch'shubham verma, Feb 9, 2021
  8. 05/10 t7001: remove whitespace after redirect operatorsshubham verma, Feb 9, 2021
  9. 06/10 t7001: avoid using `cd` outside of subshellsshubham verma, Feb 9, 2021
  10. 08/10 t7001: put each command on a separate lineshubham verma, Feb 9, 2021
  11. 10/10 t7001: use `test` rather than `[`shubham verma, Feb 9, 2021
  12. Eric SunshineFeb 9, 2021
  13. Junio C HamanoFeb 9, 2021
  14. Eric SunshineFeb 11, 2021
  15. Junio C HamanoFeb 11, 2021
  16. Shubham VermaFeb 11, 2021
  17. Eric SunshineFeb 11, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.