Re: [PATCH v2 00/10] Modernizing the t7001 test script
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 9, 2021, 22:58 UTC
- Message-ID
- <xmqqy2fwyhjy.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20210209173254.17712-1-shubhunic@gmail.com>
shubham verma <shubhunic@gmail.com> writes:
Show 26 quoted lines
> In this patch series modernize the t7001 test script by changing the > style of its tests from an old one to the modern one and by cleaning > up the test script. > > Changes since v1: > > - Change commit messages and added brief explanation about commit. > - Modernize subshell formatting > - Use ': >' rather than '>' > > Thanks everyone for your feedback and suggestions. > > shubham verma (10): > t7001: modernize test formatting > t7001: indent with TABs instead of spaces > t7001: remove unnecessary blank lines > t7001: modernize subshell formatting > t7001: remove whitespace after redirect operators > t7001: avoid using `cd` outside of subshells > t7001: use '>' rather than 'touch' > t7001: put each command on a separate line > t7001: use here-docs instead of echo > t7001: use `test` rather than `[` > > t/t7001-mv.sh | 432 ++++++++++++++++++++++++-------------------------- > 1 file changed, 204 insertions(+), 228 deletions(-)
I would have used test_write_lines instead of here-doc in 9/10, but that is such a minor preference thing that it is not worth going back and replace. Nothing else stood out during my cursory scan.
Will queue; thanks.