git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 03/10] t7001: remove unnecessary blank lines

From
shubham verma <shubhunic@gmail.com>
Date
Feb 9, 2021, 17:32 UTC
Message-ID
<20210209173254.17712-4-shubhunic@gmail.com>
In-Reply-To
<20210209173254.17712-1-shubhunic@gmail.com>

Some tests use a deprecated style in which there are unnecessary blank lines after the opening quote of the test body and before the closing quote. So we should remove these unnecessary blank lines.

Signed-off-by: shubham verma <shubhunic@gmail.com>
---
 t/t7001-mv.sh | 12 ------------
 1 file changed, 12 deletions(-)
diff --git a/t/t7001-mv.sh b/t/t7001-mv.sh
index 7503233814..f63802442b 100755
--- a/t/t7001-mv.sh
+++ b/t/t7001-mv.sh
@@ -182,7 +182,6 @@ test_expect_success "Sergey Vlasov's test case" '
 '
 
 test_expect_success 'absolute pathname' '(
-
 	rm -fr mine &&
 	mkdir mine &&
 	cd mine &&
@@ -196,12 +195,9 @@ test_expect_success 'absolute pathname' '(
 	! test -d sub &&
 	test -d in &&
 	git ls-files --error-unmatch in/file
-
-
 )'
 
 test_expect_success 'absolute pathname outside should fail' '(
-
 	rm -fr mine &&
 	mkdir mine &&
 	cd mine &&
@@ -216,7 +212,6 @@ test_expect_success 'absolute pathname outside should fail' '(
 	test -d sub &&
 	! test -d ../in &&
 	git ls-files --error-unmatch sub/file
-
 )'
 
 test_expect_success 'git mv to move multiple sources into a directory' '
@@ -232,7 +227,6 @@ test_expect_success 'git mv to move multiple sources into a directory' '
 '
 
 test_expect_success 'git mv should not change sha1 of moved cache entry' '
-
 	rm -fr .git &&
 	git init &&
 	echo 1 >dirty &&
@@ -243,7 +237,6 @@ test_expect_success 'git mv should not change sha1 of moved cache entry' '
 	echo 2 >dirty2 &&
 	git mv dirty2 dirty &&
 	[ "$entry" = "$(git ls-files --stage dirty | cut -f 1)" ]
-
 '
 
 rm -f dirty dirty2
@@ -266,7 +259,6 @@ test_expect_success 'git mv error on conflicted file' '
 '
 
 test_expect_success 'git mv should overwrite symlink to a file' '
-
 	rm -fr .git &&
 	git init &&
 	echo 1 >moved &&
@@ -279,13 +271,11 @@ test_expect_success 'git mv should overwrite symlink to a file' '
 	test "$(cat symlink)" = 1 &&
 	git update-index --refresh &&
 	git diff-files --quiet
-
 '
 
 rm -f moved symlink
 
 test_expect_success 'git mv should overwrite file with a symlink' '
-
 	rm -fr .git &&
 	git init &&
 	echo 1 >moved &&
@@ -296,11 +286,9 @@ test_expect_success 'git mv should overwrite file with a symlink' '
 	! test -e symlink &&
 	git update-index --refresh &&
 	git diff-files --quiet
-
 '
 
 test_expect_success SYMLINKS 'check moved symlink' '
-
 	test -h moved
 '
 
-- 
2.25.1
Previous: shubham vermaNext: shubham verma
Message 4 of 17 in “Modernizing the t7001 test script”
  1. 00/10 Modernizing the t7001 test scriptshubham verma, Feb 9, 2021
  2. 01/10 t7001: modernize test formattingshubham verma, Feb 9, 2021
  3. 02/10 t7001: indent with TABs instead of spacesshubham verma, Feb 9, 2021
  4. 03/10 t7001: remove unnecessary blank linesshubham verma, Feb 9, 2021
  5. 04/10 t7001: modernize subshell formattingshubham verma, Feb 9, 2021
  6. 09/10 t7001: use here-docs instead of echoshubham verma, Feb 9, 2021
  7. 07/10 t7001: use '>' rather than 'touch'shubham verma, Feb 9, 2021
  8. 05/10 t7001: remove whitespace after redirect operatorsshubham verma, Feb 9, 2021
  9. 06/10 t7001: avoid using `cd` outside of subshellsshubham verma, Feb 9, 2021
  10. 08/10 t7001: put each command on a separate lineshubham verma, Feb 9, 2021
  11. 10/10 t7001: use `test` rather than `[`shubham verma, Feb 9, 2021
  12. Eric SunshineFeb 9, 2021
  13. Junio C HamanoFeb 9, 2021
  14. Eric SunshineFeb 11, 2021
  15. Junio C HamanoFeb 11, 2021
  16. Shubham VermaFeb 11, 2021
  17. Eric SunshineFeb 11, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.