git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 09/10] t7001: use here-docs instead of echo

From
shubham verma <shubhunic@gmail.com>
Date
Feb 9, 2021, 17:32 UTC
Message-ID
<20210209173254.17712-10-shubhunic@gmail.com>
In-Reply-To
<20210209173254.17712-1-shubhunic@gmail.com>

Change from old style to current style by taking advantage of here-docs instead of echo commands.

Signed-off-by: shubham verma <shubhunic@gmail.com>
---
 t/t7001-mv.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/t/t7001-mv.sh b/t/t7001-mv.sh
index 9a73232c7c..2e2e60e0d3 100755
--- a/t/t7001-mv.sh
+++ b/t/t7001-mv.sh
@@ -226,7 +226,10 @@ test_expect_success 'git mv to move multiple sources into a directory' '
 	git add dir/?.txt &&
 	git mv dir/a.txt dir/b.txt other &&
 	git ls-files >actual &&
-	{ echo other/a.txt; echo other/b.txt; } >expect &&
+	cat >expect <<-\EOF &&
+	other/a.txt
+	other/b.txt
+	EOF
 	test_cmp expect actual
 '
 
-- 
2.25.1
Previous: shubham vermaNext: shubham verma
Message 6 of 17 in “Modernizing the t7001 test script”
  1. 00/10 Modernizing the t7001 test scriptshubham verma, Feb 9, 2021
  2. 01/10 t7001: modernize test formattingshubham verma, Feb 9, 2021
  3. 02/10 t7001: indent with TABs instead of spacesshubham verma, Feb 9, 2021
  4. 03/10 t7001: remove unnecessary blank linesshubham verma, Feb 9, 2021
  5. 04/10 t7001: modernize subshell formattingshubham verma, Feb 9, 2021
  6. 09/10 t7001: use here-docs instead of echoshubham verma, Feb 9, 2021
  7. 07/10 t7001: use '>' rather than 'touch'shubham verma, Feb 9, 2021
  8. 05/10 t7001: remove whitespace after redirect operatorsshubham verma, Feb 9, 2021
  9. 06/10 t7001: avoid using `cd` outside of subshellsshubham verma, Feb 9, 2021
  10. 08/10 t7001: put each command on a separate lineshubham verma, Feb 9, 2021
  11. 10/10 t7001: use `test` rather than `[`shubham verma, Feb 9, 2021
  12. Eric SunshineFeb 9, 2021
  13. Junio C HamanoFeb 9, 2021
  14. Eric SunshineFeb 11, 2021
  15. Junio C HamanoFeb 11, 2021
  16. Shubham VermaFeb 11, 2021
  17. Eric SunshineFeb 11, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.