Re: [PATCH] [OUTREACHY] t1002: modernize outdated conditional

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 14, 2022, 05:05 UTC
Message-ID: <xmqqy1tjatai.fsf@gitster.g>
In-Reply-To: <pull.1362.git.git.1665713184304.gitgitgadget@gmail.com>

"nsengaw4c via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: wilberforce <nsengiyumvawilberforce@gmail.com>

This name must match ...

Show 12 quoted lines

> Tests in this script use an unusual and hard to reason about
> conditional construct
>
>     if expression; then false; else :; fi
>
> Change them to use more idiomatic construct:
>
>     ! expression
>
> Cc: Christian Couder  <christian.couder@gmail.com>
> Cc: Hariom Verma <hariom18599@gmail.com>
> Signed-off-by: Nsengiyumva  wilberfore <nsengiyumvawilberforce@gmail.com>

... the name you sign-off your work with.

> -     if read_tree_u_must_succeed -m -u $treeH $treeM; then false; else :; fi'
> +     ! read_tree_u_must_succeed -m -u $treeH $treeM'

OK.