Re: [PATCH v3] [OUTREACHY] t1002: modernize outdated conditional

From: Derrick Stolee <derrickstolee@github.com>
Date: Oct 14, 2022, 17:54 UTC
Message-ID: <cc0a6adb-d894-77b3-2a65-9042237c07b5@github.com>
In-Reply-To: <CAPig+cT=bJ7BP9CDh5-oYYF376vVxsh7E0UAE_QN0wfAgR3AAg@mail.gmail.com>

On 10/14/2022 12:58 PM, Eric Sunshine wrote:

Show 23 quoted lines

> On Fri, Oct 14, 2022 at 12:35 PM Derrick Stolee
> <derrickstolee@github.com> wrote:
>> On 10/14/2022 12:15 PM, Junio C Hamano wrote:
>>> "nsengaw4c via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>>> Cc: Christian Couder  <christian.couder@gmail.com>
>>>> Cc: Hariom Verma <hariom18599@gmail.com>
>>>
>>> What are these C: lines for?  I do not think the message I am
>>> responding to is Cc'ed to them.  There may be a special incantation
>>> to tell GitGitGadget to Cc to certain folks, but adding Cc: to the
>>> log message trailer like this does not seem to be it---at least it
>>> appears that it did not work that way.
>>
>> GitGitGadget will read the "cc:" lines from the end of the pull request
>> description, not the commit messages. I'm pretty sure they will be
>> ignored if there are other lines after them.
> 
> For Wilberforce's edification for future submissions, presumably the
> reason that the CC: in the pull-request's description didn't work is
> because the CC: line wasn't the last line in the description? Does
> there need to be a blank line before the CC: line? Is it okay to list
> multiple people on the same CC: line as done in this case, or is that
> also a problem?

Looking at the PR (https://github.com/git/git/pull/1362) it seems there was no "cc:" lines in the PR description (until GitGitGadget added them due to our replies).

Nsengiyumva: you'll want to be careful to edit your pull request
description on GitHub before running the "/submit" chatop. Your
current description has a paste of your commit message followed by
the contributing template. The pull request description becomes
your cover letter (in the case of multiple patches) or a commentary
section after the commit message (in this case of a single patch).

The description is a good place to say things like "I started working on this because of a mailing list thread..." or "I'm not sure if I've tested everything enough".

The "cc:" lines should _not_ be in the commit message at all, which is what's visible in the patch.

Thanks, -Stolee