Re: [PATCH v3] [OUTREACHY] t1002: modernize outdated conditional

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Oct 14, 2022, 19:14 UTC
Message-ID: <CAPig+cR2R3EY=53ELaFY3wqy7danQmHNm0Qeqqh9nW7n8XHNHg@mail.gmail.com>
In-Reply-To: <xmqqh7068bta.fsf@gitster.g>

On Fri, Oct 14, 2022 at 3:06 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 19 quoted lines

> Eric Sunshine <sunshine@sunshineco.com> writes:
> > On Fri, Oct 14, 2022 at 12:35 PM Derrick Stolee
> > <derrickstolee@github.com> wrote:
> >> GitGitGadget will read the "cc:" lines from the end of the pull request
> >> description, not the commit messages. I'm pretty sure they will be
> >> ignored if there are other lines after them.
> >
> > For Wilberforce's edification for future submissions, presumably the
> > reason that the CC: in the pull-request's description didn't work is
> > because the CC: line wasn't the last line in the description? Does
> > there need to be a blank line before the CC: line? Is it okay to list
> > multiple people on the same CC: line as done in this case, or is that
> > also a problem?
>
> Ah, now I can see why the round v4 is CC'ed to you and Derrick on
> the list.  The pull-request text (visible in GitHub UI in the top
> most box of https://github.com/git/git/pull/1362) ends with two
> lines of cc: that list you two.  The one named Christian and Hariom
> were not at the end and was ignored by GGG, it seems.

Yes, the CC: line mentioning Christian and Hariom was not at the end of the description, which is likely why GitGitGadget didn't pick it up. (Presumably Stolee overlooked that line when responding to my question.) However, clarification about whether or not there needs to be a blank line before the CC: line would be nice (I presume the blank line is needed), but also whether or not GitGitGadget correctly deals with multiple people mentioned on the same CC: line or if they each need to occupy a single CC: line.