Re: [PATCH v2 1/5] log: Move show_blob_object() to log.c

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 20, 2024, 03:03 UTC
Message-ID: <xmqqy1bfx2f5.fsf@gitster.g>
In-Reply-To: <20240220015928.GB2713741@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

> All that said, I'm not sure based on our previous discussion why we
> can't just call stream_blob_to_fd(). Looking at show_blob_object(), most
> of the logic is about recording the tree-context of the given name and
> using it for textconv. But since we know we are feeding a bare oid,
> that would never kick in. So I don't know if there's any value in
> sharing this function more widely in the first place.

It is very nice that we do not need to touch this code move at all. Thanks, as usual, for a dose of sanity.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.