Re: [PATCH v2 1/5] log: Move show_blob_object() to log.c

From: Maarten Bosmans <mkbosmans@gmail.com>
Date: Feb 20, 2024, 11:40 UTC
Message-ID: <CA+CvcKTFSyC-76=DYDdbLV8=cou0JwexS6iFOa0P0_r5NoBEQg@mail.gmail.com>
In-Reply-To: <20240220015928.GB2713741@coredump.intra.peff.net>

Op di 20 feb 2024 om 02:59 schreef Jeff King <peff@peff.net>:

Show 6 quoted lines

> All that said, I'm not sure based on our previous discussion why we
> can't just call stream_blob_to_fd(). Looking at show_blob_object(), most
> of the logic is about recording the tree-context of the given name and
> using it for textconv. But since we know we are feeding a bare oid,
> that would never kick in. So I don't know if there's any value in
> sharing this function more widely in the first place.

Indeed. My original analysis of what `git show` does when invoked by `git notes show` led to the conclusion that the only thing worthwhile to keep is the `setup_pager()` call. Thanks for confirming this.

I'll reroll in a couple of days with the V1 approach back.

Maarten