Re: [PATCH 1/4] notes: print note blob to stdout directly

From: Maarten Bosmans <mkbosmans@gmail.com>
Date: Feb 15, 2024, 07:41 UTC
Message-ID: <CA+CvcKSpjB6Js3H49yvjNves53STj0keW3BvoREhdnDHzZ7VjQ@mail.gmail.com>
In-Reply-To: <xmqqy1bxiiop.fsf@gitster.g>

Op di 6 feb 2024 om 18:52 schreef Junio C Hamano <gitster@pobox.com>:

Show 7 quoted lines

> Maarten Bosmans <mkbosmans@gmail.com> writes:
> > That is also a cool idea. That would probably use the functionality of
> > the cat-file batch mode, right?
>
> Not really.  I was hoping that "git show" that can take multiple
> objects from its command line would directly be used, or with a new
> option that gives a separator between these objects.

OK, I need some guidance here. Should I submit a new version of the patch that addresses the comments about the code, or should I this approach of making a single `git notes show` faster altogether? In my view it is worthwhile to eliminate the extra `git show` subprocess launch (while still accounting for non-text blob notes, but not non-blob notes) and focus on batching later.

Maarten