Re: Possible git-diff bug when using exit-code with diff filters

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 21, 2024, 18:17 UTC
Message-ID: <xmqqy1961sxf.fsf@gitster.g>
In-Reply-To: <82561c70-ec33-41bf-b036-52310ffc1926@web.de>

René Scharfe <l.s.r@web.de> writes:

> You can more easily reproduce it by setting the environment variable
> GIT_EXTERNAL_DIFF or the configuration setting diff.external -- no
> attributes needed.

Indeed.

A much simpler fix may be to declare that these two features are imcompatible and fail the execution upfront, instead of just silently ignoring one of the two options.

As a person who is very much used to the external diff not contributing to the exit status (who also invented the external diff driver interface), I would be a wrong person to judge if such a simplified approach is desirable, of course, but just throwing it out as a food for thought.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.