From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 21 Apr 2024 18:17:48 GMT
Subject: Re: Possible git-diff bug when using exit-code with diff filters
Message-ID: <xmqqy1961sxf.fsf@gitster.g>
In-Reply-To: <82561c70-ec33-41bf-b036-52310ffc1926@web.de>

René Scharfe <l.s.r@web.de> writes:

> You can more easily reproduce it by setting the environment variable
> GIT_EXTERNAL_DIFF or the configuration setting diff.external -- no
> attributes needed.

Indeed.

A much simpler fix may be to declare that these two features are
imcompatible and fail the execution upfront, instead of just
silently ignoring one of the two options.

As a person who is very much used to the external diff not
contributing to the exit status (who also invented the external diff
driver interface), I would be a wrong person to judge if such a
simplified approach is desirable, of course, but just throwing it
out as a food for thought.

Thanks.