Re: Possible git-diff bug when using exit-code with diff filters

From: René Scharfe <l.s.r@web.de>
Date: May 5, 2024, 10:19 UTC
Message-ID: <caa6cca4-182f-4788-b08e-35806879fdca@web.de>
In-Reply-To: <xmqqy1961sxf.fsf@gitster.g>

Am 21.04.24 um 20:17 schrieb Junio C Hamano:

> A much simpler fix may be to declare that these two features are
> imcompatible and fail the execution upfront, instead of just
> silently ignoring one of the two options.

It would not be *that* simple -- if we want to error out upfront we'd have to evaluate the attributes of all files (or all changed files) first to see whether they require an external diff.

Reporting the incompatibility in the middle of a diff would be easier, but I don't see why we shouldn't support that combination. It takes some effort, sure, but not prohibitively much.

René

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.