git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] fetch: clobber existing tags with --prune-tags

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 13, 2026, 22:57 UTC
Message-ID
<xmqqy0d47oaq.fsf@gitster.g>
In-Reply-To
<CAGHpTBLvZGAaqkue47Ne9DHPSwxx4fPo5KusP5=sh3C2AxgAMA@mail.gmail.com>
Orgad Shaneh <orgads@gmail.com> writes:
Show 18 quoted lines
> On Thu, Mar 26, 2026 at 9:57 AM Orgad Shaneh <orgads@gmail.com> wrote:
>>
>> On Sat, Mar 21, 2026 at 8:27 PM Junio C Hamano <gitster@pobox.com> wrote:
>> >
>> > None of the steps we see in the added test do not seem to check that
>> > --prune-tags does clobber existing tag that no longer exists on the
>> > other side.  It only checks the "git fetch" command exits with
>> > status 0, but does not see if the tag actually went away after the
>> > operation is done.
>>
>> In these tests, the tag is being replaced rather than deleted. Existing
>> tests for the pruning mechanism itself are located in t/t5510-fetch.sh.
>>
>> Would you like me to add a check for the tag content itself to verify
>> the update? I suppose I should do the same for the existing test cases
>> in that block as well.
>
> Junio?

Sorry, but I do not have 6 month old discussions in my context window, so no immediate comment. I'll respond only after I swap the context back in but not today (yet).

Thanks.
Previous: Orgad ShanehNext: Orgad Shaneh
Message 8 of 9 in “fetch: clobber existing tags with --prune-tags”
  1. 0/2 fetch: clobber existing tags with --prune-tagsOrgad Shaneh via GitGitGadget, Feb 15, 2026
  2. 1/2 fetch: add a test for --force flagOrgad Shaneh via GitGitGadget, Feb 15, 2026
  3. 2/2 fetch: clobber existing tags with --prune-tagsOrgad Shaneh via GitGitGadget, Feb 15, 2026
  4. Orgad ShanehMar 18, 2026
  5. Junio C HamanoMar 21, 2026
  6. Orgad ShanehMar 26, 2026
  7. Orgad ShanehSep 13, 2026
  8. Junio C HamanoSep 13, 2026
  9. Orgad ShanehOct 6, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.