Re: [PATCH 2/2] fetch: clobber existing tags with --prune-tags

From: Orgad Shaneh <orgads@gmail.com>
Date: Sep 13, 2026, 19:03 UTC
Message-ID: <CAGHpTBLvZGAaqkue47Ne9DHPSwxx4fPo5KusP5=sh3C2AxgAMA@mail.gmail.com>
In-Reply-To: <CAGHpTBJKaTURMJmJ6W4iiCAy3-M2YWb48rF8GMoEPCfpGcE=QA@mail.gmail.com>

On Thu, Mar 26, 2026 at 9:57 AM Orgad Shaneh <orgads@gmail.com> wrote:

Show 15 quoted lines

>
> On Sat, Mar 21, 2026 at 8:27 PM Junio C Hamano <gitster@pobox.com> wrote:
> >
> > None of the steps we see in the added test do not seem to check that
> > --prune-tags does clobber existing tag that no longer exists on the
> > other side.  It only checks the "git fetch" command exits with
> > status 0, but does not see if the tag actually went away after the
> > operation is done.
>
> In these tests, the tag is being replaced rather than deleted. Existing
> tests for the pruning mechanism itself are located in t/t5510-fetch.sh.
>
> Would you like me to add a check for the tag content itself to verify
> the update? I suppose I should do the same for the existing test cases
> in that block as well.

Junio?

- Orgad