From: Junio C Hamano Date: Sun, 13 Sep 2026 22:57:01 GMT Subject: Re: [PATCH 2/2] fetch: clobber existing tags with --prune-tags Message-ID: In-Reply-To: Orgad Shaneh writes: > On Thu, Mar 26, 2026 at 9:57 AM Orgad Shaneh wrote: >> >> On Sat, Mar 21, 2026 at 8:27 PM Junio C Hamano wrote: >> > >> > None of the steps we see in the added test do not seem to check that >> > --prune-tags does clobber existing tag that no longer exists on the >> > other side. It only checks the "git fetch" command exits with >> > status 0, but does not see if the tag actually went away after the >> > operation is done. >> >> In these tests, the tag is being replaced rather than deleted. Existing >> tests for the pruning mechanism itself are located in t/t5510-fetch.sh. >> >> Would you like me to add a check for the tag content itself to verify >> the update? I suppose I should do the same for the existing test cases >> in that block as well. > > Junio? Sorry, but I do not have 6 month old discussions in my context window, so no immediate comment. I'll respond only after I swap the context back in but not today (yet). Thanks.