Re: [PATCH 3/7] t4026: test "normal" color
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 20, 2014, 18:53 UTC
- Message-ID
- <xmqqwq6p3dq3.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <20141120151609.GC23680@peff.net>
Jeff King <peff@peff.net> writes:
Show 8 quoted lines
> If the user specifiers "normal" for a foreground color, this > should be a noop (while this may sound useless, it is the > only way to specify an unchanged foreground color followed > by a specific background color). > > We also check that color "-1" does the same thing. This is > not documented, but has worked forever, so let's make sure > we keep supporting it.
YLNTED, really? I do not object to the conclusion, but I am mildly surprised ;-)
Show 25 quoted lines
> > Signed-off-by: Jeff King <peff@peff.net> > --- > t/t4026-color.sh | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/t/t4026-color.sh b/t/t4026-color.sh > index 3726a0e..63e4238 100755 > --- a/t/t4026-color.sh > +++ b/t/t4026-color.sh > @@ -53,6 +53,14 @@ test_expect_success '256 colors' ' > color "254 bold 255" "[1;38;5;254;48;5;255m" > ' > > +test_expect_success '"normal" yields no color at all"' ' > + color "normal black" "[40m" > +' > + > +test_expect_success '-1 is a synonym for "normal"' ' > + color "-1 black" "[40m" > +' > + > test_expect_success 'color too small' ' > invalid_color "-2" > '