Re: [PATCH 4/7] parse_color: refactor color storage
- From
Jeff King <peff@peff.net>
- Date
- Dec 9, 2014, 21:01 UTC
- Message-ID
- <20141209210126.GA14305@peff.net>
- In-Reply-To
- <548760FA.50209@kdbg.org>
On Tue, Dec 09, 2014 at 09:52:10PM +0100, Johannes Sixt wrote:
> This patch would actually be my personal preference. The comment near > the literal makes it all clear.
Thanks. Here it is ready to be applied.
Junio, this goes on top of the jk/colors topic.
-- >8 -- Subject: [PATCH] parse_color: drop COLOR_BACKGROUND macro
Commit 695d95d (parse_color: refactor color storage, 2014-11-20) introduced two macros, COLOR_FOREGROUND and COLOR_BACKGROUND. The latter conflicts with a system macro defined on Windows, breaking compilation there.
The simplest solution is to just get rid of these macros entirely. They are constants that are only used in one place (since the whole point of 695d95d was to avoid repeating ourselves). Their main function is to make the magic character constants more readable, but we can do the same thing with a comment.
Reported-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Jeff King <peff@peff.net> --- color.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/color.c b/color.c index e2a0a99..809b359 100644 --- a/color.c +++ b/color.c @@ -144,9 +144,6 @@ int color_parse(const char *value, char *dst) return color_parse_mem(value, strlen(value), dst); } -#define COLOR_FOREGROUND '3' -#define COLOR_BACKGROUND '4' - /* * Write the ANSI color codes for "c" to "out"; the string should * already have the ANSI escape code in it. "out" should have enough @@ -245,12 +242,14 @@ int color_parse_mem(const char *value, int value_len, char *dst) if (!color_empty(&fg)) { if (sep++) *dst++ = ';'; - dst = color_output(dst, &fg, COLOR_FOREGROUND); + /* foreground colors are all in the 3x range */ + dst = color_output(dst, &fg, '3'); } if (!color_empty(&bg)) { if (sep++) *dst++ = ';'; - dst = color_output(dst, &bg, COLOR_BACKGROUND); + /* background colors are all in the 4x range */ + dst = color_output(dst, &bg, '4'); } *dst++ = 'm'; }
-- 2.2.0.454.g7eca6b7