Re: [PATCH 4/7] parse_color: refactor color storage

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 20, 2014, 19:37 UTC
Message-ID: <xmqqlhn53bpg.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20141120151704.GD23680@peff.net>

Jeff King <peff@peff.net> writes:

> The result is also slightly less efficient to store, but
> that's OK; we only store this intermediate state during the
> parse, after which we write out the actual ANSI bytes.

You need up to 24 bits for the value and then 2 bits for what type of color specification you have (what you called "state"), for which 32-bit should be sufficient. That would mean it is more efficient than a single int on 64-bit archs, and you can arrange the struct to be packed if we ever need to keep dozens of these things. Until then, the updated simple struct is just fine, and either way it is much easier to read ;-)

Thanks.