Re: [PATCH 0/2] git-p4: Small updates to test cases

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 27, 2015, 01:26 UTC
Message-ID: <xmqqwq23w7qx.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1427418269-3263-1-git-send-email-vitor.hda@gmail.com>

Vitor Antunes <vitor.hda@gmail.com> writes:

> This patch set includes two small fixes to the rename test case. The fix to
> support dash should be trivial, but in the fix to the copy detection test case
> it isn't obvious to me what changed in diff-tree to result in a different file
> being detected as the origin of a copy.

Thanks.

As to 1/2 the lack of esac is clearly a bug---any self respecting POSIX shell should have executed it without complaining. But changing from ':' to true should not be necessary---after all, the colon is a more traditional way to spell true to Bourne shells, and we use it in many places already. Can you try reverting all the "colon to true" bits, keeping only the "add missing esac" part, and run your tests again?