git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] git-p4: Fix copy detection test

From
Vitor Antunes <vitor.hda@gmail.com>
Date
Mar 27, 2015, 23:59 UTC
Message-ID
<20150327235902.25ebf380@pt-vhugo>
In-Reply-To
<xmqq619mw04r.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
>Vitor Antunes <vitor.hda@gmail.com> writes:
>
>> File file11 is copied from file2 and diff-tree correctly reports this file as
>> its the source, but the test expression was checking for file10 instead (which
>> was a file that also originated from file2). It is possible that the diff-tree
>> algorithm was updated in recent versions, which resulted in this mismatch in
>> behavior.
>>
>> Signed-off-by: Vitor Antunes <vitor.hda@gmail.com>
>
>Pete, these tests blame to your 9b6513ac (git p4 test: split up big
>t9800 test, 2012-06-27).  I presume that you tested the result of
>this splitting, but do you happen to know if we did something to
>cause the test to break recently?

I also worked on these tests at that time and they were passing before and after the reorganization. I'll prepare a bisect script and will try to find the commit that started making this test fail.

Previous: Junio C HamanoNext: Vitor Antunes
Message 5 of 10 in “git-p4: Small updates to test cases”
  1. 0/2 git-p4: Small updates to test casesVitor Antunes, Mar 27, 2015
  2. 1/2 git-p4: Make rename test case runnable under dashVitor Antunes, Mar 27, 2015
  3. 2/2 git-p4: Fix copy detection testVitor Antunes, Mar 27, 2015
  4. Junio C HamanoMar 27, 2015
  5. Vitor AntunesMar 27, 2015
  6. Vitor AntunesMar 28, 2015
  7. Junio C HamanoMar 28, 2015
  8. Junio C HamanoMar 27, 2015
  9. Junio C HamanoMar 27, 2015
  10. Vitor AntunesMar 27, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.