git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] git-p4: Small updates to test cases

From
Vitor Antunes <vitor.hda@gmail.com>
Date
Mar 27, 2015, 01:54 UTC
Message-ID
<CAOpHH-WZXFodc3UAhdwJ6Rj1LiS-Duq2MEoN4iEtadNCT9mq5A@mail.gmail.com>
In-Reply-To
<xmqqwq23w7qx.fsf@gitster.dls.corp.google.com>
On Fri, 27 Mar 2015 at 01:26 Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
>As to 1/2 the lack of esac is clearly a bug---any self respecting
>POSIX shell should have executed it without complaining. But
>changing from ':' to true should not be necessary---after all, the
>colon is a more traditional way to spell true to Bourne shells, and
>we use it in many places already. Can you try reverting all the
>"colon to true" bits, keeping only the "add missing esac" part, and
>run your tests again?

I confirm that it still works with ':' instead of true; could swear I tested that at the time... Anyway, I'll re-submit this patch with this fixed tomorrow.

Thanks for taking the time to review the patch.
One more thing: was there any change in way diff-tree detects copies?
Previous: Junio C Hamano
Message 10 of 10 in “git-p4: Small updates to test cases”
  1. 0/2 git-p4: Small updates to test casesVitor Antunes, Mar 27, 2015
  2. 1/2 git-p4: Make rename test case runnable under dashVitor Antunes, Mar 27, 2015
  3. 2/2 git-p4: Fix copy detection testVitor Antunes, Mar 27, 2015
  4. Junio C HamanoMar 27, 2015
  5. Vitor AntunesMar 27, 2015
  6. Vitor AntunesMar 28, 2015
  7. Junio C HamanoMar 28, 2015
  8. Junio C HamanoMar 27, 2015
  9. Junio C HamanoMar 27, 2015
  10. Vitor AntunesMar 27, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.