Re: [PATCH 1/3] rebase -i: highlight problems with core.commentchar

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 22, 2016, 17:05 UTC
Message-ID: <xmqqwpfvqwbq.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1611221709180.3746@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 16 quoted lines

> On Mon, 21 Nov 2016, Junio C Hamano wrote:
>
>> diff --git a/t/t0030-stripspace.sh b/t/t0030-stripspace.sh
>> index 29e91d861c..c1f6411eb2 100755
>> --- a/t/t0030-stripspace.sh
>> +++ b/t/t0030-stripspace.sh
>> @@ -432,6 +432,15 @@ test_expect_success '-c with changed comment char' '
>>  	test_cmp expect actual
>>  '
>>  
>> +test_expect_failure '-c with comment char defined in .git/config' '
>> +	test_config core.commentchar = &&
>> +	printf "= foo\n" >expect &&
>> +	printf "foo" | (
>
> Could I ask you to sneak in a \n here?

The one before that _is_ about fixing incomplete line, but this and the one before this one are not, so I think we should fix them at the same time.

But does it break anything to leave it as-is? If not, I'd prefer to leave this (and one before this one) for a later clean-up patch post release.

Thanks