Re: [PATCH 2/3] stripspace: respect repository config

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 22, 2016, 17:10 UTC
Message-ID: <xmqqshqjqw3z.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1611221712480.3746@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 6 quoted lines

>> This conditional config file reading is a trap for similar bugs to
>> happen again. Is there any reason we should not just mark the command
>> RUN_SETUP_GENTLY in git.c and call git_config() here unconditionally?
>
> As I plan to slip these patches into Git for Windows v2.11.0, i.e. making
> this a last-minute hot fix, I want to err on the side of caution.

So do I.  As a hot-fix, I'd prefer the patch I queued yesterday.

I think we want to audit the ones without RUN_SETUP* in the command table in order to hunt for regression aka "a fix revealed a bug that was covered by .git/config accidentally getting read when run from the top-level of the working tree", though. We may find unreported breakages that we may have to fix.