git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t3900: add some more quotes

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 10, 2018, 19:43 UTC
Message-ID
<xmqqwp0p1ouf.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<6b32292b-0f71-7cf8-2069-41766d440b58@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 10 quoted lines
>>     test_expect_success 'UTF-8 invalid characters refused' '
>> -	test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" &&
>> +	test_when_finished "rm -f \"$HOME/stderr\" \"$HOME/invalid\"" &&
>
> Should that not better be
>
> 	test_when_finished "rm -f \"\$HOME/stderr\" \"\$HOME/invalid\""
>
> i.e., delay the expansion of $HOME to protect against double-quotes in
> the path?
Yes ;-)
Previous: Johannes SixtNext: Jeff King
Message 9 of 14 in “t3900: add some more quotes”
  1. t3900: add some more quotesBeat Bolli, Jan 10, 2018
  2. Jeff KingJan 10, 2018
  3. Johannes SchindelinJan 10, 2018
  4. Eric SunshineJan 10, 2018
  5. t3900: add some more quotesBeat Bolli, Jan 10, 2018
  6. Johannes SchindelinJan 10, 2018
  7. Junio C HamanoJan 10, 2018
  8. Johannes SixtJan 10, 2018
  9. Junio C HamanoJan 10, 2018
  10. Jeff KingJan 10, 2018
  11. Junio C HamanoJan 10, 2018
  12. Jeff KingJan 11, 2018
  13. read test snippet from stdin [was: [PATCH] t3900: add some more quotes]SZEDER Gábor, Jan 11, 2018
  14. Jeff KingJan 11, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.