git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t3900: add some more quotes

From
Johannes Sixt <j6t@kdbg.org>
Date
Jan 10, 2018, 19:02 UTC
Message-ID
<6b32292b-0f71-7cf8-2069-41766d440b58@kdbg.org>
In-Reply-To
<20180110095832.22077-1-dev+git@drbeat.li>
Am 10.01.2018 um 10:58 schrieb Beat Bolli:
Show 19 quoted lines
> In 89a70b80 ("t0302 & t3900: add forgotten quotes", 2018-01-03), quotes
> were added to protect against spaces in $HOME. In the test_when_finished
> hander, two files are deleted which must be quoted individually.
> 
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> ---
>   t/t3900-i18n-commit.sh | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/t/t3900-i18n-commit.sh b/t/t3900-i18n-commit.sh
> index 9e4e694d9..dc00db87b 100755
> --- a/t/t3900-i18n-commit.sh
> +++ b/t/t3900-i18n-commit.sh
> @@ -40,7 +40,7 @@ test_expect_success 'UTF-16 refused because of NULs' '
>   '
>   
>   test_expect_success 'UTF-8 invalid characters refused' '
> -	test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" &&
> +	test_when_finished "rm -f \"$HOME/stderr\" \"$HOME/invalid\"" &&
Should that not better be
	test_when_finished "rm -f \"\$HOME/stderr\" \"\$HOME/invalid\""

i.e., delay the expansion of $HOME to protect against double-quotes in the path?

-- Hannes
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 14 in “t3900: add some more quotes”
  1. t3900: add some more quotesBeat Bolli, Jan 10, 2018
  2. Jeff KingJan 10, 2018
  3. Johannes SchindelinJan 10, 2018
  4. Eric SunshineJan 10, 2018
  5. t3900: add some more quotesBeat Bolli, Jan 10, 2018
  6. Johannes SchindelinJan 10, 2018
  7. Junio C HamanoJan 10, 2018
  8. Johannes SixtJan 10, 2018
  9. Junio C HamanoJan 10, 2018
  10. Jeff KingJan 10, 2018
  11. Junio C HamanoJan 10, 2018
  12. Jeff KingJan 11, 2018
  13. read test snippet from stdin [was: [PATCH] t3900: add some more quotes]SZEDER Gábor, Jan 11, 2018
  14. Jeff KingJan 11, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.