From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 10 Jan 2018 19:43:52 GMT
Subject: Re: [PATCH] t3900: add some more quotes
Message-ID: <xmqqwp0p1ouf.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <6b32292b-0f71-7cf8-2069-41766d440b58@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

>>     test_expect_success 'UTF-8 invalid characters refused' '
>> -	test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" &&
>> +	test_when_finished "rm -f \"$HOME/stderr\" \"$HOME/invalid\"" &&
>
> Should that not better be
>
> 	test_when_finished "rm -f \"\$HOME/stderr\" \"\$HOME/invalid\""
>
> i.e., delay the expansion of $HOME to protect against double-quotes in
> the path?

Yes ;-)