Re: [PATCH v2 0/8] ref-in-want

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 15, 2018, 21:20 UTC
Message-ID: <xmqqwouzycey.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180613213925.10560-1-bmwill@google.com>

Brandon Williams <bmwill@google.com> writes:

> Changes in v2:
> * issuing a want-ref line to a ref which doesn't exist is just ignored.
> * fixed some typos

Do I lock some (logical) prerequisite changes? On 2.18-rc2 they apply cleanly but the series fails its own test.

t5703-upload-pack-ref-in-want.sh
expecting success:
        test-pkt-line pack >in <<-EOF &&
        command=fetch
        0001
        no-progress
        want-ref refs/heads/non-existent
        done
        0000
        EOF

        test_must_fail git serve --stateless-rpc 2>out <in &&
        grep "unknown ref" out

test_must_fail: command succeeded: git serve --stateless-rpc not ok 3 - invalid want-ref line

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.