Re: [PATCH v4 6/8] fetch: refactor to make function args narrower

From: Jonathan Tan <jonathantanmy@google.com>
Date: Jun 25, 2018, 22:36 UTC
Message-ID: <20180625223639.203642-1-jonathantanmy@google.com>
In-Reply-To: <20180625185332.164142-7-bmwill@google.com>

Show 5 quoted lines

> Refactor find_non_local_tags and get_ref_map to only take the
> information they need instead of the entire transport struct. Besides
> improving code clarity, this also improves their flexibility, allowing
> for a different set of refs to be used instead of relying on the ones
> stored in the transport struct.

I see that due to the narrowing of get_ref_map() to take the refs (and the remote) instead of the whole transport, the computation of the refs (including computation of the ref prefixes) is also moved from get_ref_map() to its caller, do_fetch(). As in a previous patch, get_ref_map() is only used once, so this movement is safe.

Reviewed-by: Jonathan Tan <jonathantanmy@google.com>