Re: [PATCH v5 8/8] fetch-pack: implement ref-in-want
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Jun 27, 2018, 18:09 UTC
- Message-ID
- <20180627180943.35472-1-jonathantanmy@google.com>
- In-Reply-To
- <20180626205438.110764-9-bmwill@google.com>
> +test_expect_success 'setup repos for change-while-negotiating test' '
The tests that follow are basic ref-in-want tests, not tests on a repo that changes during negotiation - this would be just "setup repos for fetch tests".
Show 9 quoted lines
> +test_expect_success 'fetching with exact OID' ' > + rm -rf local && > + cp -r "$LOCAL_PRISTINE" local && > + git -C local fetch origin $(git -C "$REPO" rev-parse d):refs/heads/actual && > + > + git -C "$REPO" rev-parse "d" >expected && > + git -C local rev-parse refs/heads/actual >actual && > + test_cmp expected actual > +'
Also verify that "want-ref refs/tags/d" is being sent over the wire, and not any "want ...". (If not we can't distinguish these from the usual non-want-ref behavior.) Same comment for the other tests.
Other than that (and my other comments), this patch series looks good.