Re: [PATCH 2/7] grep.c: expose {,inverted} match column in match_line()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 19, 2018, 16:49 UTC
- Message-ID
- <xmqqwouuvi0e.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <d0a6b3ca2a8e67c6a5ed4d2c56c5121d4bc3554b.1529365072.git.me@ttaylorr.com>
Taylor Blau <me@ttaylorr.com> writes:
Show 7 quoted lines
> case GREP_NODE_NOT: > - h = !match_expr_eval(x->u.unary, bol, eol, ctx, 0); > + /* > + * Upon visiting a GREP_NODE_NOT, imatch and match become > + * swapped. > + */ > + h = !match_expr_eval(x->u.unary, bol, eol, ctx, icol, col, 0);
A minor nit, but the comment talks about something that are different from the variable names; perhaps you called col/icol with different names in an earlier incarnation of this patch?