Re: [PATCH 0/7] grep.c: teach --column to 'git-grep(1)'

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 19, 2018, 16:46 UTC
Message-ID: <xmqq1sd2wwpz.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <cover.1529365072.git.me@ttaylorr.com>

Taylor Blau <me@ttaylorr.com> writes:

Show 8 quoted lines

> Attached is a ``fresh start'' of my series to teach 'git grep --column'.
> Since the last time I sent this, much has changed, notably the semantics
> for deciding which column is the first when given (1) extended
> expressions and (2) --invert.
> ...
> In the future, I'd like to revisit this, since any performance gains
> that we _do_ make in this area are moot when we rescan all lines in
> show_line() with --color.

Sounds like a plan. From a quick scan, it seems that this is sufficiently different from the last round so I won't bother rebuilding your "--only" series on top, and instead just drop those two series from the older round and queue this as the new and improved tb/grep-column topic.

Thanks.