Re: [PATCH 0/7] grep.c: teach --column to 'git-grep(1)'
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 19, 2018, 18:09 UTC
- Message-ID
- <xmqqfu1iveaw.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180619180525.GA28203@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 8 quoted lines
> Even if it's a double-inversion? The reason we carry both `col` and > `icol` is that it allows: > > git grep --not --not --not --not -e a > > to still say "we found 'a' here". That's a dumb thing to ask for, but it > is true in the end that we show lines with "a" (and will colorize them > as such).
Yes. I think the code is doing too much to cater to a dumb request ;-)